Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CHaP in preparation for cardano-node 8.8 #529

Merged
merged 10 commits into from
Feb 6, 2024
Merged

Bump CHaP in preparation for cardano-node 8.8 #529

merged 10 commits into from
Feb 6, 2024

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Dec 20, 2023 •
edited
Loading

Depends on: IntersectMBO/cardano-api#407

Changelog

- description: |
    - Bump CHaP in preparation for cardano-node 8.8
    - `--pool-retirement-epoch-boundary` updated to `--pool-retirement-epoch-interval`
    - `--governance-action-lifetime` and  `--drep-activity` parse an `EpochInterval`
    - Treasury withdrawals and protocol parameter updates now optionally parse a guard rail script
    - `transaction build` and `transaction build-raw` commands now parse optional Plutus script witnesses for votes and proposals
    - The "tx body intermediate format" is now fully deprecated
    - Protocol parameter parsers are updated as follows:
      - `pMaxBodySize :: Parser Word32`
      - `pMaxBlockHeaderSize :: Parser Word32`
      - `pCommitteeTermLength :: Parser EpochInterval`
    - New `--pool-voting-threshold-pp-security-group` parser added for protocol parameter updates in the Conway era
    
    
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-chap-20231220 branch 2 times, most recently from d3223a2 to aaa7981 Compare December 20, 2023 17:29
@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-chap-20231220 branch from 87863de to 1f1b475 Compare January 2, 2024 20:04
@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-chap-20231220 branch 2 times, most recently from f0b88fb to c7ffca3 Compare January 29, 2024 23:58
@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-chap-20231220 branch from c2071d3 to 7f83efd Compare January 30, 2024 22:47
@Jimbo4350 Jimbo4350 changed the title Bump CHaP Bump CHaP in preparation for cardano-node 8.8 Jan 31, 2024
@Jimbo4350 Jimbo4350 changed the title Bump CHaP in preparation for cardano-node 8.8 WIP: Bump CHaP in preparation for cardano-node 8.8 Jan 31, 2024
@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-chap-20231220 branch 9 times, most recently from 07b8725 to b3aaf9f Compare February 1, 2024 22:01
@Jimbo4350 Jimbo4350 changed the title WIP: Bump CHaP in preparation for cardano-node 8.8 Bump CHaP in preparation for cardano-node 8.8 Feb 1, 2024
@Jimbo4350 @carbolymer
Update pGovActionLifetime, pDRepActivity and pEpochBoundRetirement with
48f3bad 
EpochInterval
Implement AnyTxCmdTxExecUnitsErr and AnyTxBodyErrorAutoBalance to wrap
TransactionValidityError era and TxBodyErrorAutoBalance era respectively
@Jimbo4350 @carbolymer
Add consitution script hash argument to the governance action
8f55104 
'create-treasury-withdrawal' command
@Jimbo4350 @carbolymer
Update transaction build and transaction build-raw parsers with the
ce2bbb8 
ability to submit script witnesses for votes and proposals
@Jimbo4350 @carbolymer
Include potential voting and proposing script witness reference inputs
4e516f1 
in 'getAllReferenceInputs'
Update 'readVotingProceduresFiles' and 'readSingleVote' to also read script witnesses
Update 'readTxGovernanceActions' and 'readProposal' to also read script witnesses
Fix incorrect error type in 'readTxGovernanceActions'
Implement 'convToTxProposalProcedures' and 'convertToTxVotingProcedures'
which gathers the necessary script witnesses for us as a conventient
'Map'
@Jimbo4350 @carbolymer
Update golden files
bc5964f 
Remove cli tx body intermediate format backwards compatibility test
@Jimbo4350 @carbolymer
Update protocol parameters parsers:
1727293 
- pMaxBodySize :: Parser Word32
- pMaxBlockHeaderSize :: Parser Word32
- pCommitteeTermLength :: Parser EpochInterval
Add new parser for the voting threshold of the protocol parameters
security group
@Jimbo4350 @carbolymer
Update Maybe ChainPoint to Target ChainPoint
bba84d8
@carbolymer carbolymer force-pushed the jordan/bump-chap-20231220 branch 3 times, most recently from 87b1222 to 9be1f21 Compare February 6, 2024 16:09
@carbolymer carbolymer force-pushed the jordan/bump-chap-20231220 branch from 9be1f21 to 26fb079 Compare February 6, 2024 16:13
@carbolymer carbolymer enabled auto-merge February 6, 2024 17:04
@carbolymer carbolymer added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit 760a6f5 Feb 6, 2024
16 checks passed
@carbolymer carbolymer deleted the jordan/bump-chap-20231220 branch February 6, 2024 17:47
This was referenced Mar 4, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jimbo4350 @carbolymer